fix(macos): show capsule in fullscreen Spaces#556
Merged
H-Chris233 merged 2 commits intoMay 31, 2026
Merged
Conversation
PR Reviewer Guide 🔍(Review updated until commit a5970f8)Here are some key observations to aid the review process:
|
|
Persistent review updated to latest commit a5970f8 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Summary
NSWindowCollectionBehavior::FullScreenAuxiliaryto the macOS capsule no-activate show path.CanJoinAllSpacesandorderFrontRegardlessso the capsule remains visible without focusing OpenLess.Fixes #548
Test Plan
npm --prefix "openless-all/app" run check:macos-capsule-spacescargo test --manifest-path "openless-all/app/src-tauri/Cargo.toml" capsule_show_strategy_matches_platform_activation_contract -- --test-threads=1npm --prefix "openless-all/app" run buildgit diff --checkNotes
cargo check --manifest-path "openless-all/app/src-tauri/Cargo.toml" --target x86_64-apple-darwincannot complete on this Linux machine because the macOS SDK is unavailable (TargetConditionals.hmissing from theringbuild). Real macOS fullscreen smoke testing is still required.PR Type
Bug fix, Tests
Description
Enable capsule in fullscreen Spaces
Preserve no-activate display behavior
Add contract coverage for auxiliary windows
Diagram Walkthrough
File Walkthrough
coordinator.rs
Add fullscreen auxiliary capsule behavioropenless-all/app/src-tauri/src/coordinator.rs
CanJoinAllSpacesandFullScreenAuxiliaryto the capsule window.orderFrontRegardlessno-activate show path intact.macos-capsule-spaces-contract.test.mjs
Extend macOS capsule spaces contractopenless-all/app/scripts/macos-capsule-spaces-contract.test.mjs
FULL_SCREEN_AUXILIARYbehavior.